cubrid support #81
Open
cubrid support #81
+532
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piers-williams
requested changes
Apr 28, 2025
| return FileUtils.copyToString( | ||
| Objects.requireNonNull( | ||
| CUBRIDDatabaseExtension.class.getClassLoader().getResourceAsStream( | ||
| "org/flywaydb/community/database/database/version.txt")), |
There was a problem hiding this comment.
Suggested change
| "org/flywaydb/community/database/database/version.txt")), | |
| "org/flywaydb/community/database/cubrid/version.txt")), |
Comment on lines
+1
to
+19
| /*- | ||
| * ========================LICENSE_START================================= | ||
| * flyway-database-cubrid | ||
| * ======================================================================== | ||
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | ||
| * ======================================================================== | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * =========================LICENSE_END================================== | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /*- | |
| * ========================LICENSE_START================================= | |
| * flyway-database-cubrid | |
| * ======================================================================== | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * ======================================================================== | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| * =========================LICENSE_END================================== | |
| */ |
Comment on lines
+1
to
+19
| /*- | ||
| * ========================LICENSE_START================================= | ||
| * flyway-database-cubrid | ||
| * ======================================================================== | ||
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | ||
| * ======================================================================== | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * =========================LICENSE_END================================== | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /*- | |
| * ========================LICENSE_START================================= | |
| * flyway-database-cubrid | |
| * ======================================================================== | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * ======================================================================== | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| * =========================LICENSE_END================================== | |
| */ | |
| /* | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| */ |
Comment on lines
+1
to
+19
| /*- | ||
| * ========================LICENSE_START================================= | ||
| * flyway-database-cubrid | ||
| * ======================================================================== | ||
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | ||
| * ======================================================================== | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * =========================LICENSE_END================================== | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /*- | |
| * ========================LICENSE_START================================= | |
| * flyway-database-cubrid | |
| * ======================================================================== | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * ======================================================================== | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| * =========================LICENSE_END================================== | |
| */ | |
| /* | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| */ |
Comment on lines
+1
to
+19
| /*- | ||
| * ========================LICENSE_START================================= | ||
| * flyway-database-cubrid | ||
| * ======================================================================== | ||
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | ||
| * ======================================================================== | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * =========================LICENSE_END================================== | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /*- | |
| * ========================LICENSE_START================================= | |
| * flyway-database-cubrid | |
| * ======================================================================== | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * ======================================================================== | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| * =========================LICENSE_END================================== | |
| */ | |
| /* | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| */ |
Comment on lines
+1
to
+19
| /*- | ||
| * ========================LICENSE_START================================= | ||
| * flyway-database-cubrid | ||
| * ======================================================================== | ||
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | ||
| * ======================================================================== | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * =========================LICENSE_END================================== | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /*- | |
| * ========================LICENSE_START================================= | |
| * flyway-database-cubrid | |
| * ======================================================================== | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * ======================================================================== | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| * =========================LICENSE_END================================== | |
| */ | |
| /* | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| */ |
Comment on lines
+1
to
+19
| /*- | ||
| * ========================LICENSE_START================================= | ||
| * flyway-database-cubrid | ||
| * ======================================================================== | ||
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | ||
| * ======================================================================== | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * =========================LICENSE_END================================== | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /*- | |
| * ========================LICENSE_START================================= | |
| * flyway-database-cubrid | |
| * ======================================================================== | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * ======================================================================== | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| * =========================LICENSE_END================================== | |
| */ | |
| /* | |
| * Copyright (C) 2010 - 2025 Red Gate Software Ltd | |
| * | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| */ |
| import org.flywaydb.core.extensibility.PluginMetadata; | ||
| import org.flywaydb.core.internal.util.FileUtils; | ||
|
|
||
| public class CUBRIDDatabaseExtension implements PluginMetadata { |
There was a problem hiding this comment.
Suggested change
| public class CUBRIDDatabaseExtension implements PluginMetadata { | |
| public class CubridDatabaseExtension implements PluginMetadata { |
I see that the database is supposed to be upper case but I think for classes we should stick to the standard for Java. If you could change all of them that would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I do not have any official affiliation with CUBRID, nor do I consider myself an expert on it. While working on a production deployment that required schema migrations, I realized that Flyway did not support CUBRID. To address this, I implemented the necessary changes to enable compatibility and would like to share my contribution with the community in case it may be helpful to others.
I would greatly appreciate any feedback you may have, and I am more than happy to make any necessary improvements.
Thank you!